Z-Image: no attention mask if attention mask is a no-op#13184
Open
dxqb wants to merge 4 commits intohuggingface:mainfrom
Open
Z-Image: no attention mask if attention mask is a no-op#13184dxqb wants to merge 4 commits intohuggingface:mainfrom
dxqb wants to merge 4 commits intohuggingface:mainfrom
Conversation
Contributor
|
LGTM! @yiyixuxu, could you please take a look and merge if everything is fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please see #12893 (comment)
this is a PR against release v.0.36.0, therefore currently not mergable.
I can change that if and when this PR is agreed upon.
@ChrisLiu6